Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML support for unsaved XML, XSD and XSL files #156

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Add XML support for unsaved XML, XSD and XSL files #156

merged 1 commit into from
Jun 17, 2019

Conversation

xorye
Copy link

@xorye xorye commented Jun 14, 2019

Very likely fixes the cause of #154

When creating a new file (without saving) and setting the language mode to XML, no requests were being sent to the language server.

This PR allows requests to be sent for files that are not saved on the local file system.

Signed-off-by: David Kwon [email protected]

@fbricon fbricon added this to the 0.8.0 milestone Jun 17, 2019
Copy link
Collaborator

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@fbricon fbricon merged commit 7eafbc3 into redhat-developer:master Jun 17, 2019
@fbricon fbricon removed this from the 0.8.0 milestone Jun 17, 2019
@xorye xorye mentioned this pull request Jul 23, 2019
@angelozerr angelozerr changed the title Registers language server for newly created unsaved XML files Add XML support for unsaved XML, XSD and XSL files Jul 23, 2019
@angelozerr angelozerr added this to the 0.8.0 milestone Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants