Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lemminx-alpine server not found #1015

Closed
cirolosapio opened this issue Jul 8, 2024 · 3 comments · Fixed by #1016
Closed

lemminx-alpine server not found #1015

cirolosapio opened this issue Jul 8, 2024 · 3 comments · Fixed by #1016
Labels
binary bug Something isn't working
Milestone

Comments

@cirolosapio
Copy link
Contributor

the alpine version is present
image

but the extension is looking for the linux one

[Error - 11:49:40 AM] XML Support client: couldn't create connection to server.
Launching server using command /home/vscode/.vscode-server-insiders/extensions/redhat.vscode-xml-0.27.2024053103-alpine-x64/server/lemminx-linux failed. Error: spawn /home/vscode/.vscode-server-insiders/extensions/redhat.vscode-xml-0.27.2024053103-alpine-x64/server/lemminx-linux ENOENT
@rgrunber
Copy link
Member

I think the problem is around https://github.com/redhat-developer/vscode-xml/pull/991/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R131 right ? Instead of naming the binary lemminx-alpine, we just need to name it lemminx-linux, although it does get packaged into the alpine vsix. We also need to make sure it doesn't clash with the non-static lemminx-linux binary that is destined for the linux vsix.

@cirolosapio
Copy link
Contributor Author

but the binaries are different because they are built with different flags
I think the extension should look for the correct os, see #1016

@rgrunber
Copy link
Member

Initially I didn't want to have the runtime code change, as I felt it was better to just modify how we package it. After all, we can definitely have 2 files (lemminx-linux) exist in separate packages. The problem is these files can exist independently and we do sort of encourage users to download them separately at https://github.com/redhat-developer/vscode-xml/releases/tag/0.27.1 . If a user has some file named lemminx-linux it becomes harder to figure out immediately which it is (without asking them to do an ldd). Also might complicate the checksum situation.

So yeah, I think your approach is the right one.

@rgrunber rgrunber added this to the 0.27.2 milestone Jul 17, 2024
@rgrunber rgrunber added bug Something isn't working binary labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants