Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Ip address for telemetry #576

Merged
merged 1 commit into from
May 19, 2021

Conversation

sudhirverma
Copy link
Contributor

Added regex to hide Ip address

@sudhirverma sudhirverma changed the title Hide Ip address Hide Ip address fro telemetry May 12, 2021
@sudhirverma sudhirverma changed the title Hide Ip address fro telemetry Hide Ip address for telemetry May 12, 2021
@sudhirverma sudhirverma requested a review from evidolob May 12, 2021 06:59
@codecov-commenter
Copy link

Codecov Report

Merging #576 (9c8a728) into master (31fdd36) will increase coverage by 0.01%.
The diff coverage is 80.00%.

❗ Current head 9c8a728 differs from pull request most recent head 850b2f8. Consider uploading reports for the commit 850b2f8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   67.64%   67.65%   +0.01%     
==========================================
  Files          99       99              
  Lines        6141     6146       +5     
  Branches     1054     1055       +1     
==========================================
+ Hits         4154     4158       +4     
- Misses       1987     1988       +1     
Impacted Files Coverage Δ
src/util/hideclusterinformation.ts 80.00% <80.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fdd36...850b2f8. Read the comment docs.

Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudhirverma Coul you add tests for this?

@sudhirverma sudhirverma requested a review from evidolob May 14, 2021 19:41
Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, what about ipv6?

@sudhirverma sudhirverma merged commit 85eed35 into redhat-developer:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants