Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing java.semanticHighlighting.enabled does not consistently update semantic tokens #1678

Closed
0dinD opened this issue Oct 28, 2020 · 0 comments · Fixed by #1679
Closed

Comments

@0dinD
Copy link
Contributor

0dinD commented Oct 28, 2020

Most java settings take immediate effect without requiring a reload, which is a great user experience. However, the java.semanticHighlighting.enabled setting does not always update the semantic tokens in the editor when changed. This is very confusing, especially when you aren't even notified that a reload is required to see the change.

Environment
  • Java extension version: 0.69.0
Steps To Reproduce, case 1
  1. Make sure that semantic highlighting is enabled.
  2. Open any Java file where semantic highlighting can be seen.
  3. Set java.semanticHighlighting.enabled to false.
  4. Notice how the opened Java file still has semantic tokens, until completely reloaded.
Current Result

semantic-highlighting-setting-1

Steps To Reproduce, case 2
  1. Open any Java file where semantic highlighting can be seen.
  2. Change any setting other than java.semanticHighlighting.enabled.
  3. Change java.semanticHighlighting.enabled to true or false.
  4. Notice how the setting does not take effect.
Current Result

semantic-highlighting-setting-2

Expected Result

semantic-highlighting-setting-3

Additional Information

I will submit a PR with a fix for this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants