Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize environment variable based configuration #6149

Closed
Tracked by #5871
feloy opened this issue Sep 21, 2022 · 0 comments · Fixed by #6293
Closed
Tracked by #5871

Centralize environment variable based configuration #6149

feloy opened this issue Sep 21, 2022 · 0 comments · Fixed by #6293
Assignees
@feloy
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Milestone
v3.3.0 🚀

Comments

@feloy
Copy link
Contributor

feloy commented Sep 21, 2022

/kind feature

Which functionality do you think we should add?

Have a centralized point for configuration based on environment variable.

This package can help:
https://github.com/kelseyhightower/envconfig

Why is this needed?

It is for the moment impossible to know (except from doc) which are the environment variables used for configuring odo
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 21, 2022
@rm3l rm3l added this to odo Project Oct 3, 2022
@rm3l rm3l moved this to To Do 📝 in odo Project Oct 3, 2022
@rm3l rm3l removed the status in odo Project Oct 3, 2022
@feloy feloy mentioned this issue Oct 4, 2022
Closed
25 tasks
@rm3l rm3l added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Oct 6, 2022
@rm3l rm3l modified the milestone: v3.3.0 🚀 Oct 26, 2022
@feloy feloy mentioned this issue Nov 8, 2022
Merged
3 tasks
@feloy feloy moved this to In Progress 🚧 in odo Project Nov 8, 2022
@rm3l rm3l added this to the v3.3.0 🚀 milestone Nov 9, 2022
@feloy feloy moved this from In Progress 🚧 to In Review 👀 in odo Project Nov 9, 2022
Repository owner moved this from In Review 👀 to Done ✅ in odo Project Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
odo Project
Archived in project
Milestone
v3.3.0 🚀
Development

Successfully merging a pull request may close this issue.

Centralize environment configuration feloy/odo
2 participants
@rm3l @feloy