Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support openshift Devfile components (the same way as kubernetes components) #5704

Closed
rm3l opened this issue Apr 29, 2022 · 2 comments · Fixed by #6548
Closed

Support openshift Devfile components (the same way as kubernetes components) #5704

rm3l opened this issue Apr 29, 2022 · 2 comments · Fixed by #6548
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. pair programming Issue that is a good candidate for pair programming priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Milestone

Comments

@rm3l
Copy link
Member

rm3l commented Apr 29, 2022

/kind feature

Stumbled upon this while working on #5451

Which functionality do you think we should add?

openshift components should have been deprecated and removed from the Devfile specification, but this is currently not the case. So odo should support them.

Why is this needed?

At this time, running odo deploy with an openshift component does not output any error/warning messages, and does not deploy the component either, which seems quite confusing.
For example, running odo deploy with the following devfile.yaml succeeds with the following message: Your Devfile has been successfully deployed, but nothing was actually deployed.

After a discussion with @kadel:

So there is a history behind openshfit component in devfile. It was there in devfile v1, and it got carried over to devfile v2, but the decision was made that it doesn't make much sense to have both openshift and kubernetes components when they are doing the same thing and that having just kubernetes component is ok.
But it looks like it was never deprecated from the spec.
That is why it was never implemented.
But because it looks like it was never deprecated, and removing it would mean breaking change in spec, we will have to support it now.

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Apr 29, 2022
@rm3l rm3l changed the title Support "openshift" components (the same way as "kubernetes" components) Support Openshift components (the same way as Kubernetes components) Apr 29, 2022
@rm3l rm3l changed the title Support Openshift components (the same way as Kubernetes components) Support openshift Devfile components (the same way as kubernetes components) Apr 29, 2022
@rm3l rm3l added area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. and removed kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Apr 29, 2022
@kadel kadel added this to the v3.0.0-beta2 milestone May 6, 2022
@kadel kadel removed this from the v3.0.0-beta2 milestone Jun 1, 2022
@rm3l rm3l added this to odo Project Oct 3, 2022
@rm3l rm3l moved this to To Do 📝 in odo Project Oct 3, 2022
@rm3l rm3l removed the status in odo Project Oct 3, 2022
@kadel kadel added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Jan 10, 2023
@rm3l
Copy link
Member Author

rm3l commented Jan 19, 2023

Grooming (2023-01-19)

  • Idea to make odo convert OpenShift components into K8s components right after parsing the Devfile. Beware of side effects
  • Implement as simple case .. which should behave the same way as K8s components.

@valaparthvi valaparthvi added the sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint. label Jan 25, 2023
@rm3l rm3l added the pair programming Issue that is a good candidate for pair programming label Jan 30, 2023
@rm3l rm3l moved this to In Progress 🚧 in odo Project Jan 30, 2023
@rm3l
Copy link
Member Author

rm3l commented Jan 30, 2023

After starting pair programming on this issue today, we noticed that running "odo dev" with a Devfile containing an OpenShift component would create this resource on the cluster, but immediately delete it afterward. This seems due to #6189, because only Kubernetes components are being loaded from the Devfile.
So we need to fix this behavior.

After digging further, we'll also need to check all places where Devfile K8s components are being loaded and handle OpenShift components accordingly. So this might affect the following commands as well:

  • describe component: we need also to show OpenShift components in the human-readable output
  • delete component: resources created for OpenShift components are currently not detected as candidates for deletion
  • dev: K8s components not referenced by any apply command are automatically created by odo dev. This should also be the case for OpenShift components.

@rm3l rm3l added this to the v3.7.0 🚀 milestone Jan 30, 2023
@rm3l rm3l linked a pull request Feb 1, 2023 that will close this issue
3 tasks
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✅ in odo Project Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. pair programming Issue that is a good candidate for pair programming priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants