Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Error, If multiple commands of same kind specified in devfile v2 and none is default #3271

Closed
adisky opened this issue Jun 1, 2020 · 5 comments
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation

Comments

@adisky
Copy link
Contributor

adisky commented Jun 1, 2020

/kind feature

Which functionality do you think we should add?

Currently for devfile V2, we are allowing users to specify multiple commands of same kind, and selecting the first command from the list, if none of them is default.

We need to throw error for following case "Multiple build command specified in devfile with no default"

commands:
  - exec:
      id: build the app
      component: tools
      commandLine: "/artifacts/bin/build-container-full.sh"
      workingDir: /projects/springbootproject
      group:
        kind: build
  - exec:
      id: build
      component: runtime
      commandLine: "mvn compile"
      workingDir: /
      group:
        kind: build

Why is this needed?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 1, 2020
@adisky adisky added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 1, 2020
@girishramnani
Copy link
Contributor

  • multiple build commands is a valid use case
  • but having no default build command should fail either way.

@maysunfaisal
Copy link
Contributor

I think this can be covered by issue #2938
since I am working on #2938, I can take this issue
/assign

@kadel kadel added area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. and removed area/devfileV2 labels Jun 25, 2020
@maysunfaisal
Copy link
Contributor

maysunfaisal commented Jun 29, 2020

can be closed, fixed by #3291

@adisky
Copy link
Contributor Author

adisky commented Jun 30, 2020

/close

@openshift-ci-robot
Copy link
Collaborator

@adisky: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
None yet
Development

No branches or pull requests

5 participants