Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring enabled false does not seem to do anything #818

Open
joyartoun opened this issue Dec 2, 2024 · 0 comments
Open

monitoring enabled false does not seem to do anything #818

joyartoun opened this issue Dec 2, 2024 · 0 comments

Comments

@joyartoun
Copy link

joyartoun commented Dec 2, 2024

Describe the bug
According to the gitops operator documentation Setting

spec:
  monitoring:
    enabled: false

On the argocd instance yaml should disable and remove the prometheusrule created by the operator for that specific argocd instance. However the flag does not seem to do anything.

I think the bug in question lies in this block Where there is a check for if the flag Spec.Monitoring.DisableMetrics is true or defined. But no check for the flag Spec.Monitoring.enabled exists it seems.
There should be a way to keep the metrics but also disable the alerting rules, but setting Spec.Monitoring.DisableMetrics to true disables all of it.

To Reproduce
Steps to reproduce the behavior:
Set:

spec:
  monitoring:
    enabled: false

On the argocd instance.
Wait for the rule to be deleted.
Nothing happens.
Delete the rule manually and see that the operator recreates it.

Expected behavior
I expect the operator to remove the prometheus rule from the openshift cluster, as the documentation describes.

Additional context
Alerts from other teams argocd instances are flooding the openshift console notification bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants