feat: add dev preview capability #668
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,43 @@ | ||
| // This file contains functions that add common arguments to the command line | ||
| package arguments | ||
|
|
||
| import ( | ||
| "strings" | ||
|
|
||
| "github.com/redhat-developer/app-services-cli/internal/config" | ||
| "github.com/redhat-developer/app-services-cli/pkg/cmd/debug" | ||
| "github.com/redhat-developer/app-services-cli/pkg/cmd/factory" | ||
| "github.com/spf13/pflag" | ||
| ) | ||
|
|
||
| // AddDebugFlag adds the '--debug' flag to the given set of command line flags | ||
| func AddDebugFlag(fs *pflag.FlagSet) { | ||
| debug.AddFlag(fs) | ||
| } | ||
|
|
||
| // Enables dev preview in config | ||
| func EnableDevPreview(f *factory.Factory, enablement *string) (*config.Config, error) { | ||
| if *enablement == "" { | ||
| // Flag not present no action needed. | ||
| return nil, nil | ||
| } | ||
|
|
||
| logger, err := f.Logger() | ||
| if err != nil { | ||
| logger.Info("Cannot enable dev preview") | ||
|
There was a problem hiding this comment. That will fail because the logger is not created. |
||
| return nil, err | ||
| } | ||
| config, err := f.Config.Load() | ||
| if err != nil { | ||
| logger.Info("Cannot enable dev preview") | ||
| return nil, err | ||
| } | ||
|
|
||
| config.DevPreviewEnabled = strings.ToLower(*enablement) == "true" || *enablement == "yes" || *enablement == "y" | ||
| err = f.Config.Save(config) | ||
| if err != nil { | ||
| logger.Info("Cannot enable dev preview") | ||
| return nil, err | ||
| } | ||
| return config, err | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // This file contains functions that help to manage visibility of early stage commands | ||
| package profile | ||
|
|
||
| import ( | ||
| "strings" | ||
|
|
||
| "github.com/redhat-developer/app-services-cli/internal/config" | ||
| "github.com/redhat-developer/app-services-cli/pkg/cmd/factory" | ||
| "github.com/redhat-developer/app-services-cli/pkg/color" | ||
| ) | ||
|
|
||
| // Visual element displayed in help | ||
| func DevPreviewLabel() string { | ||
| return color.Info("[Preview] ") | ||
| } | ||
|
|
||
| // Annotation used in templates and tools like documentation generation | ||
| func DevPreviewAnnotation() map[string]string { | ||
| return map[string]string{"channel": "preview"} | ||
| } | ||
|
|
||
| // Check if preview is enabled | ||
| func DevPreviewEnabled(f *factory.Factory) bool { | ||
| logger, err := f.Logger() | ||
| if err != nil { | ||
| logger.Info("Cannot determine status of dev preview. ", err) | ||
| return false | ||
| } | ||
| config, err := f.Config.Load() | ||
| if err != nil { | ||
| logger.Info("Cannot determine status of dev preview. ", err) | ||
| return false | ||
| } | ||
|
|
||
| return config.DevPreviewEnabled | ||
| } | ||
|
|
||
| // Enable dev preview | ||
| func EnableDevPreview(f *factory.Factory, enablement *string) (*config.Config, error) { | ||
| if *enablement == "" { | ||
| // Flag not present no action needed. | ||
| return nil, nil | ||
| } | ||
|
|
||
| logger, err := f.Logger() | ||
| if err != nil { | ||
| logger.Info("Cannot enable dev preview. ", err) | ||
| return nil, err | ||
| } | ||
| config, err := f.Config.Load() | ||
| if err != nil { | ||
| logger.Info("Cannot enable dev preview.", err) | ||
| return nil, err | ||
| } | ||
|
|
||
| config.DevPreviewEnabled = strings.ToLower(*enablement) == "true" || *enablement == "yes" || *enablement == "y" | ||
| err = f.Config.Save(config) | ||
| if err != nil { | ||
| logger.Info("Cannot enable dev preview. ", err) | ||
| return nil, err | ||
| } | ||
| logger.Info("Successfully changed visibility of devpreview commands") | ||
| return config, err | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| package profile | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/redhat-developer/app-services-cli/pkg/cmd/factory" | ||
| ) | ||
|
|
||
| func TestEnableDevPreviewConfig(t *testing.T) { | ||
| testVal := "" | ||
| config, err := EnableDevPreview(factory.New("dev", nil), &testVal) | ||
| if config != nil { | ||
| t.Errorf("TestEnableDevPreviewConfig config = %v, want %v", config, nil) | ||
| } | ||
| if err != nil { | ||
| t.Errorf("TestEnableDevPreviewConfig error = %v, want %v", err, nil) | ||
| } | ||
|
|
||
| testVal = "giberish" | ||
| config, err = EnableDevPreview(factory.New("dev", nil), &testVal) | ||
| if config.DevPreviewEnabled == true { | ||
| t.Errorf("TestEnableDevPreviewConfig() config.DevPreviewEnabled = %v, want %v", config.DevPreviewEnabled, false) | ||
| } | ||
| if err != nil { | ||
| t.Errorf("TestEnableDevPreviewConfig error = %v, want %v", err, nil) | ||
| } | ||
|
|
||
| testVal = "true" | ||
| config, err = EnableDevPreview(factory.New("dev", nil), &testVal) | ||
| if config.DevPreviewEnabled != true { | ||
| t.Errorf("TestEnableDevPreviewConfig config.DevPreviewEnabled = %v, want %v", config.DevPreviewEnabled, true) | ||
| } | ||
| if err != nil { | ||
| t.Errorf("TestEnableDevPreviewConfig error = %v, want %v", err, nil) | ||
| } | ||
|
|
||
| testVal = "yes" | ||
| config, err = EnableDevPreview(factory.New("dev", nil), &testVal) | ||
| if config.DevPreviewEnabled != true { | ||
| t.Errorf("TestEnableDevPreviewConfig config.DevPreviewEnabled = %v, want %v", config.DevPreviewEnabled, true) | ||
| } | ||
| if err != nil { | ||
| t.Errorf("TestEnableDevPreviewConfig error = %v, want %v", err, nil) | ||
| } | ||
| } | ||
|
|
||
| func TestDevPreviewEnabled(t *testing.T) { | ||
| f := factory.New("dev", nil) | ||
| testVal := "false" | ||
| config, _ := EnableDevPreview(f, &testVal) | ||
| t.Log("Ess", config) | ||
| enabled := DevPreviewEnabled(f) | ||
|
|
||
| if enabled { | ||
| t.Errorf("TestEnableDevPreviewConfig enabled = %v, want %v", enabled, false) | ||
| } | ||
|
|
||
| testVal = "true" | ||
| _, _ = EnableDevPreview(f, &testVal) | ||
|
|
||
| enabled = DevPreviewEnabled(f) | ||
| if !enabled { | ||
| t.Errorf("TestEnableDevPreviewConfig enabled = %v, want %v", enabled, true) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do i18n as last step on the feature branch. Ignore non externalized strings for now