Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serviceaccount create): display processing text while creation #465

Merged
merged 1 commit into from
Mar 16, 2021
Merged

fix(serviceaccount create): display processing text while creation #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/rhoas/pkged.go
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions locales/cmd/serviceaccount/create/active.en.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ one = 'Description for the service account.'
description = 'Error message when service account could not be created'
one = 'could not create service account'

[serviceAccount.create.log.info.creating]
one = 'Creating service account "{{.Name}}"'

[serviceAccount.create.log.info.createdSuccessfully]
one = 'Service account "{{.Name}}" created successfully with ID "{{.ID}}".'

Expand Down
7 changes: 7 additions & 0 deletions pkg/cmd/serviceaccount/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,5 +238,12 @@ func runInteractivePrompt(opts *Options) (err error) {
return err
}

logger.Info(localizer.MustLocalize(&localizer.Config{
MessageID: "serviceAccount.create.log.info.creating",
TemplateData: map[string]interface{}{
"Name": opts.name,
},
}))

return nil
}