Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(topic): condition should check if topic name is empty #985

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

craicoverflow
Copy link
Contributor

The topic create command should be checking if the topic name is "" when in a non-TTY session.

Verification Steps

Create a topic in a detached terminal session:

true | (setsid ./rhoas kafka topic create --name topic2) 2>&1

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@craicoverflow craicoverflow merged commit cca1abf into main Aug 30, 2021
@craicoverflow craicoverflow deleted the fix-topic-create-tty branch August 30, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants