Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add title and description to the flags #953

Merged
merged 3 commits into from
Aug 23, 2021
Merged

fix: add title and description to the flags #953

merged 3 commits into from
Aug 23, 2021

Conversation

wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Aug 20, 2021 •
edited
Loading

Added --version, --title and --description flags that can be now supplied as optional arguments:

rhoas service-registry artifact create --artifact-id=test  --version=1.0 --title=test --description=test artifact.json
rhoas service-registry artifact update --artifact-id=test --version=1.0 --title=test --description=test artifact.json

@wtrocki wtrocki linked an issue Aug 20, 2021 that may be closed by this pull request
Missing flags for rhoas service-registry artifact metadata #932
Closed
@wtrocki wtrocki removed a link to an issue Aug 20, 2021
Missing flags for rhoas service-registry artifact metadata #932
Closed
@wtrocki wtrocki linked an issue Aug 20, 2021 that may be closed by this pull request
rhoas service-registry artifact create should support additional flags #929
Closed
@wtrocki wtrocki requested a review from rkpattnaik780 August 23, 2021 11:55
@wtrocki wtrocki marked this pull request as ready for review August 23, 2021 11:55
@wtrocki
Copy link
Collaborator Author

wtrocki commented Aug 23, 2021

I think we should always encode details.

@wtrocki wtrocki requested a review from craicoverflow August 23, 2021 13:53
@wtrocki
Copy link
Collaborator Author

wtrocki commented Aug 23, 2021

Thank you @craicoverflow

@wtrocki wtrocki merged commit 3b92a5a into main Aug 23, 2021
@wtrocki wtrocki deleted the 929 branch August 23, 2021 15:24
craicoverflow pushed a commit that referenced this pull request Aug 30, 2021
@wtrocki
fix: add title and description to the flags (#953)
38bade8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craicoverflow craicoverflow craicoverflow approved these changes

@rkpattnaik780 rkpattnaik780 Awaiting requested review from rkpattnaik780

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rhoas service-registry artifact create should support additional flags
2 participants
@wtrocki @craicoverflow