Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: locale key err in cluster_kubernetes #900

Merged
merged 1 commit into from
Aug 12, 2021
Merged

fix: locale key err in cluster_kubernetes #900

merged 1 commit into from
Aug 12, 2021

Conversation

ankithans
Copy link
Contributor

@ankithans ankithans commented Aug 12, 2021 •
edited by craicoverflow
Loading

Closes #899

Verification Steps

  1. Do rhoas cluster status

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@craicoverflow craicoverflow self-requested a review August 12, 2021 08:57
@craicoverflow craicoverflow merged commit e5ad8c5 into redhat-developer:main Aug 12, 2021
@ankithans ankithans deleted the issue/899 branch August 12, 2021 08:58
@wtrocki
Copy link
Collaborator

wtrocki commented Aug 12, 2021

I was always calling this command with positive/happy scenario results, thus never seen that error. Nice catch!

craicoverflow pushed a commit that referenced this pull request Aug 30, 2021
@ankithans
fix: locale key err in cluster_kubernetes (#900)
7a0d563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craicoverflow craicoverflow Awaiting requested review from craicoverflow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct key cluster.kubernetes.error.configNotFoundError in cluster_kubernetes.en.toml
3 participants
@ankithans @wtrocki @craicoverflow