Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service-account): remove period from description validation error #891

Merged
merged 1 commit into from
Aug 11, 2021
Merged

fix(service-account): remove period from description validation error #891

merged 1 commit into from
Aug 11, 2021

Conversation

rkpattnaik780
Copy link
Contributor

The service-account description validation error message ended with a period which added an extra dot to message printed by terminal.

Screenshot from 2021-08-11 16-07-45

Closes #

Verification Steps

  1. Do x
  2. Do y

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@wtrocki wtrocki merged commit c08519d into main Aug 11, 2021
@wtrocki wtrocki deleted the svc_acc_desc_fix branch August 11, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craicoverflow craicoverflow craicoverflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkpattnaik780 @craicoverflow @wtrocki