Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): set "locales" as root dir #847

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

craicoverflow
Copy link
Contributor

@craicoverflow craicoverflow commented Jul 28, 2021

I did some investigation and believe that there are no issues in any libraries we are using and this could be resolved by changing the root directory of the locales.

go-i18n loads files from the root "locales" directory. The same root should be used when walking the file tree.

Closes #828

Verification Steps

On a Windows machine do the following:

  1. Run rhoas
  2. If successful, the CLI will print the help text to the console.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

go-i18n loads files from the root "locales" directory.
This should be the root when walking the file tree.
@craicoverflow craicoverflow marked this pull request as ready for review July 28, 2021 13:49
@craicoverflow craicoverflow merged commit 5ecbf82 into main Jul 28, 2021
@craicoverflow craicoverflow deleted the fix-locales-root branch July 28, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI not working on Windows 10
1 participant