Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service-account): reset-credentials prompt #838

Merged
merged 1 commit into from
Jul 22, 2021
Merged

fix(service-account): reset-credentials prompt #838

merged 1 commit into from
Jul 22, 2021

Conversation

rkpattnaik780
Copy link
Contributor

Skip flag validations for interactive mode.

Closes #837

Verification Steps

  1. Try to run reset-credentials in interactive mode.
go run ./cmd/rhoas service-account reset-credentials
  1. It should prompt for values.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@wtrocki
Copy link
Collaborator

wtrocki commented Jul 22, 2021

Good catch. thx for quick fix

@rkpattnaik780 rkpattnaik780 merged commit c3dd044 into main Jul 22, 2021
@rkpattnaik780 rkpattnaik780 deleted the reset_cred_prompt branch July 22, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive mode not working for service account reset-credentials
2 participants
@rkpattnaik780 @wtrocki