Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka consumer-group): use group id filter for dynamic completions #827

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

rkpattnaik780
Copy link
Contributor

Dynamic completions for kafka consumer-group describe and kafka consumer-group delete used to fetch all the consumer groups instead of filtering(as it was not present in server).

Verification Steps

  1. Create some consumer groups using bin scripts.
  2. Press tab twice after setting some initial text for --id flag of kafka consumer-group describe command.
./rhoas kafka consumer-group describe --id co

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@rkpattnaik780 rkpattnaik780 merged commit 6511f14 into main Jul 21, 2021
@rkpattnaik780 rkpattnaik780 deleted the consumer_group_offset branch July 21, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants