Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consumer-group list): add flags for pagination #821

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

rkpattnaik780
Copy link
Contributor

BREAKING: flag for deprecated field limit has been removed

Closes #766

Verification Steps

  1. List consumer groups after specifying value for --page and --size flag.
./rhoas kafka consumer-group list --page 1 --size 20
  1. Passing --limit to consumer-group list command should throw error unknown flag: --limit
./rhoas kafka consumer-group list --limit 100

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

BREAKING: flag for deprecated field limit has been removed
@rkpattnaik780 rkpattnaik780 requested a review from wtrocki July 14, 2021 11:49
@rkpattnaik780 rkpattnaik780 merged commit 706f0d6 into main Jul 15, 2021
@rkpattnaik780 rkpattnaik780 deleted the consumer_group branch July 15, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination on the topic list and consumergroup list commands
2 participants