Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove URL from table view for serviceregistry list command #809

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Jul 7, 2021

rhoas service-registry list should not return url as it is very long and obfuscates entire table

Impact of the change

Pre:

  ID   NAME   REGISTRY URL                                                                                                           OWNER                  STATUS  
 ---- ------ ---------------------------------------------------------------------------------------------------------------------- ---------------------- -------- 
  3    test   https://service-registry-stage.apps.app-sre-stage-0.k3s7.p1.openshiftapps.com/t/3b8ae86d-1478-4aa8-8b7a-a45d43e299d8   wtrocki_kafka_devexp   ready  

Post:

[wtrocki@graphapi app-services-cli (registry-table)]$ rhoas service-registry list
 ID (4)    NAME    OWNER                  STATUS  
--------- ------- ---------------------- -------- 
 3         test    wtrocki_kafka_devexp   ready   
 4         test2   wtrocki_kafka_devexp   ready   
 5         test3   wtrocki_kafka_devexp   ready   
 6         test4   wtrocki_kafka_devexp   ready   

@wtrocki wtrocki requested a review from craicoverflow July 7, 2021 13:43
@wtrocki
Copy link
Collaborator Author

wtrocki commented Jul 7, 2021

Not sure about this so looking for feedback rather than review

@famarting
Copy link
Contributor

don't put the url in the list and only make it available for describe or json/yaml output

@wtrocki wtrocki changed the title chore: Remove URL from table view for serviceregistry list command fix: Remove URL from table view for serviceregistry list command Jul 7, 2021
@craicoverflow craicoverflow changed the title fix: Remove URL from table view for serviceregistry list command fix!: Remove URL from table view for serviceregistry list command Jul 7, 2021
@wtrocki wtrocki merged commit 6b1ea24 into main Jul 7, 2021
@wtrocki wtrocki deleted the registry-table branch July 7, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants