-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create folder for the config #806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had issues when setting the custom config location:
❯ export RHOASCONFIG=~/.rhoascustom
❯ ./rhoas whoami
unable to read config file: read /home/ephelan/.rhoascustom: is a directory
I think if RHOASCONFIG
is set, and the directory does not exist we should not try to create the directory for them. Only when the system defaulr dir does not exist should we create it.
Actually handling for RHOASCONFIG is done in other place. |
This is much cleaner now |
The only thing that is see right now is that you still going to get default folder created even if custom location is set. |
We could also check if the env is set, and only create the folder if it is not set. But I'm happpy with how it is right now. |
@craicoverflow I tried to add |
I think that would be good right now |
No description provided.