Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kafka topic update): add cleanup policy flag #776

Merged
merged 2 commits into from
Jul 2, 2021
Merged

feat(kafka topic update): add cleanup policy flag #776

merged 2 commits into from
Jul 2, 2021

Conversation

rkpattnaik780
Copy link
Contributor

User should be able to update cleanup policy of a Kafka topic.

Closes #772

Verification Steps

  1. Update a Kafka topic while passing the --cleanup-policy flag.
  2. Update a Kafka topic in interactive mode

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@rkpattnaik780 rkpattnaik780 merged commit 33df2ee into main Jul 2, 2021
@rkpattnaik780 rkpattnaik780 deleted the cleanup_policy_update branch July 2, 2021 11:30
@rkpattnaik780 rkpattnaik780 mentioned this pull request Jul 2, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craicoverflow craicoverflow craicoverflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to update the cleanup policy for a Kafka topic
2 participants
@rkpattnaik780 @craicoverflow