fix: fix not working insecure login #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use oauth2.HTTPClient to perform login As the go-oidc provider can obtain the custom transport layer from the context
|
cc @akoserwal |
craicoverflow
changed the title
|
Verified. it works |
craicoverflow
pushed a commit
that referenced
this pull request
Jun 30, 2021
craicoverflow
pushed a commit
that referenced
this pull request
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use oauth2.HTTPClient to perform login
As the go-oidc provider can obtain the custom transport layer
from the context
Closes #
Verification Steps
Run login against a custom auth URL:
./rhoas login --auth-url "https://keycloakexternal.apps.akoserwa.ipt.integrations.rhmw.io/auth/realms/redhat-external" --insecureType of change
Checklist