Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add basic documentation #67

Merged
merged 5 commits into from
Nov 17, 2020
Merged

fix: add basic documentation #67

merged 5 commits into from
Nov 17, 2020

Conversation

wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Nov 17, 2020

Couple guys pointed out that there is no simple way to start without going to the docs folder that is outdated. Trick is to point out to login command and mention kafka commands.

Couple guys pointed out that there is no simple way to start without going to the docs folder that is outdated.
@wtrocki
Copy link
Collaborator Author

wtrocki commented Nov 17, 2020

@craicoverflow @machi1990 this might be controversial but I think it is also valuable to link the quickstart in the readme. They use CLI and are the most client facing artifact we have right now.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Enda <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@craicoverflow craicoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Co-authored-by: Enda <[email protected]>
@wtrocki
Copy link
Collaborator Author

wtrocki commented Nov 17, 2020

Done!

@craicoverflow craicoverflow merged commit 2efe4c3 into main Nov 17, 2020
@craicoverflow craicoverflow deleted the basic-docs branch November 17, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants