feat: use production APIs by default #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craicoverflow
commented
Apr 20, 2021
Comment on lines
+34
to
+44
| // Auth Build variables | ||
| var ( | ||
| ProductionAPIURL = "https://api.openshift.com" | ||
| StagingAPIURL = "https://api.stage.openshift.com" | ||
| DefaultClientID = "rhoas-cli-prod" | ||
| DefaultOfflineTokenClientID = "cloud-services" | ||
| ProductionAuthURL = "https://sso.redhat.com/auth/realms/redhat-external" | ||
| ProductionMasAuthURL = "https://identity.api.openshift.com/auth/realms/rhoas" | ||
| StagingMasAuthURL = "https://identity.api.stage.openshift.com/auth/realms/rhoas" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Centralised Auth config, as they were duplicated and hard to maintain.
There was a problem hiding this comment.
These can be made cofigurable later, through go build.
BREAKING CHANGE: The default API and Auth endpoints now point to the production environment by default.
wtrocki
approved these changes
Apr 20, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the rhoas CLI will log in to
https://api.openshift.comAPI instead ofhttps://api.stage.openshift.com, andhttps://identity.api.openshift.com/auth/realms/rhoasinstead ofhttps://identity.api.stage.openshift.com/auth/realms/rhoas.Verification
Run
rhoas loginto log in.https://identity.api.stage.openshift.com/auth/realms/rhoaswill not work yet until the server-side switch is complete, so you can runrhoas login --mas-auth-url=staging.