Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topic): Show 'Unlimited' when value is -1 #559

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

craicoverflow
Copy link
Contributor

Description

Resolves #488

The -1 value for retention size and retention period means "Unlimited". This adds "Unlimited" to the table alongside the true value of -1.

Verification Steps

Run rhoas kafka topic list:

❯ rhoas kafka topic list
  NAME             PARTITIONS   RETENTION TIME   RETENTION SIZE  
 ---------------- ------------ ---------------- ---------------- 
  strimzi-canary            3   604800000        -1 (Unlimited)  
  topic-1                   1   -1 (Unlimited)   -1 (Unlimited)  
  topic-2                   1   1000000          -1 (Unlimited)

@craicoverflow
Copy link
Contributor Author

@rkpattnaik780 you might want to have something similar in the UI?

@craicoverflow craicoverflow merged commit 3acb6e4 into redhat-developer:main Apr 12, 2021
@craicoverflow craicoverflow deleted the unlimited-column branch April 12, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to topic list
1 participant