Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for generating modular docs #504

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Conversation

pmuir
Copy link
Collaborator

@pmuir pmuir commented Mar 26, 2021

Description

Add support for converting the docs produced by the Command Line Interface docs generator to the "modular docs" format and pushing them to the modular-docs branch on very push to main. This allows other systems to then pick them up as needed.

Verification Steps

  1. Run make docs/generate-modular-docs
  2. Inspect the output in dist
  3. On merging the PR, the branch modular-docs should be populated with the contents of the dist dir

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@pmuir pmuir requested review from craicoverflow and wtrocki and removed request for craicoverflow March 26, 2021 16:23
@pmuir pmuir force-pushed the generate-modular-docs branch from 68efe53 to d95aa5d Compare March 26, 2021 16:27
@wtrocki
Copy link
Collaborator

wtrocki commented Mar 26, 2021

👁️

@wtrocki
Copy link
Collaborator

wtrocki commented Mar 26, 2021

@pmuir Any example of another system to validate file structure.
Got structure working locally, tried job on my fork.

All seems to be working. The only trick is to prevent things from changing in future as any structure change will need developer to adjust scripts.

To fully understand it - other systems will be syncing this branch itself - means that they will be responsible for versioning etc.?

Makefile Show resolved Hide resolved
@wtrocki
Copy link
Collaborator

wtrocki commented Mar 26, 2021

FYI Generated files have
ifdef::env-github,env-browser[:relfilesuffix: .adoc] which is upstream fix - not an issue but not needed for downstream

Checked previews and github links - all works!

@pmuir
Copy link
Collaborator Author

pmuir commented Mar 26, 2021

@pmuir Any example of another system to validate file structure.
Got structure working locally, tried job on my fork.

For example https://github.com/bf2fc6cc711aee1a0c2a/guides/tree/modular-docs

All seems to be working. The only trick is to prevent things from changing in future as any structure change will need developer to adjust scripts.

Yes, though given the docs are all generated, that probably isn't a major issue.

To fully understand it - other systems will be syncing this branch itself - means that they will be responsible for versioning etc.?

Right.

@wtrocki
Copy link
Collaborator

wtrocki commented Mar 26, 2021

Good to merge

@bhardesty
Copy link
Contributor

I verified that this works for me. I did have some scripting to build the assembly from the CLI, but this works just as well. The only issue would be it would be slightly more complicated if we ever wanted to change something like the assembly intro text.

@pmuir
Copy link
Collaborator Author

pmuir commented Mar 26, 2021

FYI Generated files have
ifdef::env-github,env-browser[:relfilesuffix: .adoc] which is upstream fix - not an issue but not needed for downstream

Checked previews and github links - all works!

This is the recommended way to handle links that work on both github and in other systems.

@pmuir pmuir merged commit 2261348 into main Mar 26, 2021
@pmuir pmuir deleted the generate-modular-docs branch March 26, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants