Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(serviceaccount create): display processing text while creation #465

Merged
merged 1 commit into from
Mar 16, 2021
Merged

fix(serviceaccount create): display processing text while creation #465

merged 1 commit into from
Mar 16, 2021

Conversation

rkpattnaik780
Copy link
Contributor

Description

Show a processing text when the service account is being created.

Screenshot from 2021-03-16 12-51-27

Fixes #447

Verification Steps

  1. Run go run ./cmd/rhoas serviceaccount create.
  2. Enter the values prompted.
  3. After entering the description, the CLI should show Creating service account "<service-account-name>"

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@rkpattnaik780 rkpattnaik780 requested a review from wtrocki March 16, 2021 10:30
@rkpattnaik780 rkpattnaik780 merged commit 08c35f6 into main Mar 16, 2021
@rkpattnaik780 rkpattnaik780 deleted the service_acc_delay branch March 16, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service account creation bugs
2 participants
@rkpattnaik780 @wtrocki