fix(serviceaccount create): allow absolute paths when passing custom file location #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #435
This PR does three things:
67a4f08 fixes an error where the user's custom credentials file path was assume to be a relative path and the CLI was converting it from an assumed relative path to an absolute path. The fix removes any modification to the custom path.
b055229 adds a missing
--force
flag to theserviceaccount reset-credentials
command.cc35b29 lets users pass an environment variable in their file path
Verification Steps
67a4f08
/home/your-username/file.json
b055229
Run the reset service account command with the
--force
flag:Type of change
Checklist