fix: make binding executable directly in the bash #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,6 +57,7 @@ Waiting for status from ManagedKafkaConnection resource. | |||
| Created ManagedKafkaConnection can be already injected to your application | |||
| by creating Service Binding (requires ServiceBindingOperator): | |||
|
|
|||
| cat <<EOF | kubectl apply -f - | |||
There was a problem hiding this comment.
This should print to stdout.
There was a problem hiding this comment.
Would it be possible to ensure order of the messages ?
I really want this to be also printed in the bash in proper order.
There was a problem hiding this comment.
It should be split into three messages.
There was a problem hiding this comment.
Ah.. ok so bash will print both error and stdout.
- printErr(Success)
- printSTD binding
- printErro more bessages
Great idea! Will do that today!
wtrocki
force-pushed
the
binding-bash
branch
2 times, most recently
from
c0838d5 to
8842cac
Compare
|
Verification: |
|
FYI @secondsun :) might be handy for end to end testing sandbox :D |
7 tasks
craicoverflow
suggested changes
Mar 4, 2021
craicoverflow
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported by evaluator #418
Based on https://kubernetes.io/docs/reference/kubectl/cheatsheet/#creating-objects