feat(serviceaccount describe): add describe command #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craicoverflow
approved these changes
Mar 2, 2021
| res, _, apiErr := a.Execute() | ||
|
|
||
| if apiErr.Error() != "" { | ||
| return fmt.Errorf("%v: %w", localizer.MustLocalizeFromID("serviceAccount.describe.error.unableToDescribe"), apiErr) |
There was a problem hiding this comment.
I think we need to handle service account API errors better, because this just prints the status code.
This is happening in all service account commands though, so it is a separate task.
|
Requires rebase. |
rkpattnaik780
force-pushed
the
serviceaccount_describe
branch
from
764046c to
8293551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serviceaccount describesubcommand has been added to display configuration details of a specific service account.fixes #335