Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native asciidoc renderer for docs #362

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

pmuir
Copy link
Collaborator

@pmuir pmuir commented Feb 19, 2021

Initial work on #354

@pmuir pmuir changed the title [WIP add native asciidoc renderer for docs [WIP] add native asciidoc renderer for docs Feb 19, 2021
@@ -0,0 +1,115 @@
# Generating Markdown Docs For Your Own cobra.Command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Generating Markdown Docs For Your Own cobra.Command
# Generating Asciidoc Docs For Your Own cobra.Command

@@ -0,0 +1,115 @@
# Generating Markdown Docs For Your Own cobra.Command

Generating Markdown pages from a cobra command is incredibly easy. An example is as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Generating Markdown pages from a cobra command is incredibly easy. An example is as follows:
Generating Asciidoc pages from a cobra command is incredibly easy. An example is as follows:

@pmuir pmuir force-pushed the 354 branch 2 times, most recently from 5fa0771 to a2cc3c4 Compare February 19, 2021 18:46
@pmuir pmuir changed the title [WIP] add native asciidoc renderer for docs feat: add native asciidoc renderer for docs Feb 19, 2021
@pmuir
Copy link
Collaborator Author

pmuir commented Feb 19, 2021

@craicoverflow ready for review.

@wtrocki
Copy link
Collaborator

wtrocki commented Feb 19, 2021

make lint && make format needed.
I could do that but changes are on fork. Best to push to upstream next time for us to fix minor stuff

@wtrocki
Copy link
Collaborator

wtrocki commented Feb 19, 2021

Verified. Leaving this for Enda to have final approve

@craicoverflow craicoverflow merged commit 4157670 into redhat-developer:main Feb 22, 2021
@craicoverflow craicoverflow deleted the 354 branch February 22, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants