Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh token if no access token is provided #326

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

pmuir
Copy link
Collaborator

@pmuir pmuir commented Feb 5, 2021

(Needed for offline tokens)

@pmuir pmuir requested a review from craicoverflow February 5, 2021 19:33
@wtrocki
Copy link
Collaborator

wtrocki commented Feb 5, 2021

While this works (I have verified it) it is not possible to get that use case in the CLI (only SDK) since login will get token as well, so we can remove the token from config and use it. Would chat with @craicoverflow to see if we can get to use offline token in CLI as some undocumented feature ( I would love that from personal point of view because we need to login every day to the CLI and this clashes with Jira login)

@wtrocki wtrocki merged commit c931bd2 into main Feb 5, 2021
@wtrocki wtrocki deleted the offline_tokens branch February 5, 2021 21:01
@pmuir
Copy link
Collaborator Author

pmuir commented Feb 5, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants