Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-registry create): improve error handling #1814

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

rkpattnaik780
Copy link
Contributor

Improve error handling of service registry create command.

Closes #1714

Verification Steps

  1. Try creating a registry instance with same name when user has quota:
rhoas service-registry create --name test

It should throw the error: Instance with name "test" already exists

  1. Try creating a registry instance when user has exhausted quota:
    It should throw the error: Instance cannot be created. You have reached the limit of service registry instances per user.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Copy link
Contributor

@jackdelahunt jackdelahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackdelahunt jackdelahunt merged commit 4512b73 into main Feb 23, 2023
@jackdelahunt jackdelahunt deleted the registry_conflict branch February 23, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry create doesnt handle evaluation error properly
2 participants