Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector cluster): add update command #1789

Merged
merged 3 commits into from
Dec 16, 2022
Merged

feat(connector cluster): add update command #1789

merged 3 commits into from
Dec 16, 2022

Conversation

rkpattnaik780
Copy link
Contributor

Add connector cluster update command with flags to change name and annotations.

Verification Steps

  1. Build the CLI locally
make binary
  1. Run the connector cluster update command:
./rhoas connector cluster update --id <cluster-id> --name test-rename --annotations="environment=production,app=nginx" -v

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

jackdelahunt
jackdelahunt reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@jackdelahunt jackdelahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think we just need more error handling for this

pkg/cmd/connector/cluster/update/update.go
Comment on lines +96 to +98
if apiErr.GetCode() == connectorerror.ERROR_7 {
return opts.f.Localizer.MustLocalizeError("connector.cluster.update.error.notFound", localize.NewEntry("ID", opts.id))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there should be more errors here to catch here

@dhirajsb
Copy link

functionally lgtm

jackdelahunt
jackdelahunt approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@jackdelahunt jackdelahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkpattnaik780
Copy link
Contributor Author

functionally lgtm

Thank you.

@rkpattnaik780 rkpattnaik780 merged commit cf0ebc0 into main Dec 16, 2022
@rkpattnaik780 rkpattnaik780 deleted the connector_0.10.0 branch December 16, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackdelahunt jackdelahunt jackdelahunt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkpattnaik780 @dhirajsb @jackdelahunt