Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(namespace create): remove eval from examples #1788

Merged
merged 1 commit into from
Dec 9, 2022
Merged

fix(namespace create): remove eval from examples #1788

merged 1 commit into from
Dec 9, 2022

Conversation

rkpattnaik780
Copy link
Contributor

Remove "--eval" flag from examples.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@rkpattnaik780
Copy link
Contributor Author

@jackdelahunt . Can you confirm the texts removed are okay or they need to be substituted with something else?

jackdelahunt
jackdelahunt approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@jackdelahunt jackdelahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rkpattnaik780 rkpattnaik780 merged commit 29a4906 into main Dec 9, 2022
@rkpattnaik780 rkpattnaik780 deleted the remove_eval branch December 9, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackdelahunt jackdelahunt jackdelahunt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkpattnaik780 @jackdelahunt