Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector update): populate kafka url #1786

Merged
merged 5 commits into from
Jan 12, 2023
Merged

fix(connector update): populate kafka url #1786

merged 5 commits into from
Jan 12, 2023

Conversation

rkpattnaik780
Copy link
Contributor

@rkpattnaik780 rkpattnaik780 commented Dec 5, 2022 •
edited
Loading

Closes #

Verification Steps

  1. Run the following command to update a connector instance by id:
rhoas connector update --kafka-id ce6pg07k09f3rs6us7sg --id ce6tgb1mk0orirpo5i70
  1. Ensure that the connectors instance has been updated, and the new Kafka URL has been specified.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@rkpattnaik780 rkpattnaik780 marked this pull request as ready for review December 5, 2022 14:45
@rkpattnaik780 rkpattnaik780 marked this pull request as draft December 5, 2022 15:09
jackdelahunt
jackdelahunt approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@jackdelahunt jackdelahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkpattnaik780 rkpattnaik780 marked this pull request as ready for review January 12, 2023 10:58
@rkpattnaik780 rkpattnaik780 merged commit ddd600f into main Jan 12, 2023
@rkpattnaik780 rkpattnaik780 deleted the connector_update_doc branch January 12, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackdelahunt jackdelahunt jackdelahunt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkpattnaik780 @jackdelahunt