Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(documentation): Use right flags for export command #1775

Merged
merged 2 commits into from
Oct 28, 2022
Merged

fix(documentation): Use right flags for export command #1775

merged 2 commits into from
Oct 28, 2022

Conversation

rmarting
Copy link
Contributor

@rmarting rmarting commented Oct 28, 2022 •
edited
Loading

The current export command text is not aligned with the real flags used by the command.

The command requires to use output-file however the help sais to use file flag.

Verification Steps

  1. Display the export help: `rhoas service-registry artifact export --help'
  2. Execute the export: rhoas service-registry artifact export --output-file=export.zip

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • [] Other (please specify)

@rmarting
🩹 Use right flags for export command
5f9f0ab 
Help text and real export flags are not aligned (one uses `file` and other `output-file`)
@rmarting rmarting changed the title 🩹 Use right flags for export command fix(documentation): Use right flags for export command Oct 28, 2022
rkpattnaik780
rkpattnaik780 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@rkpattnaik780 rkpattnaik780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @rmarting :).

@rkpattnaik780 rkpattnaik780 merged commit b3fa74b into redhat-developer:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkpattnaik780 rkpattnaik780 rkpattnaik780 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmarting @rkpattnaik780