Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(namespace): fix namespace name logging #1773

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

avano
Copy link
Contributor

@avano avano commented Oct 26, 2022

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Fixes an issue with namespace create command:

Successfully created the "<no value>" namespace &{Name my-namespace}

Also fixes an issue where the name logged is always from the --name command option, not from the actual namespace created

@avano avano force-pushed the namespace-create-fix branch from 64d6f18 to c898018 Compare October 26, 2022 09:01
@jackdelahunt
Copy link
Contributor

Created a namespace with the pr and the issue with localizer is fixed but there is no name being displayed.

➜  app-services-cli git:(namespace-create-fix) ./rhoas connector namespace create
{
  "annotations": {
    "connector_mgmt.bf2.org/profile": "evaluation-profile"
  },
  "cluster_id": "c9nrsjtcqpu8pmmjl5vg",
  "created_at": "2022-10-27T11:09:40.274733Z",
  "expiration": "2022-10-29T11:09:40.27169Z",
  "href": "/api/connector_mgmt/v1/kafka_connector_namespaces/cdd6dt0oj57achspmeig",
  "id": "cdd6dt0oj57achspmeig",
  "kind": "ConnectorNamespace",
  "modified_at": "2022-10-27T11:09:40.274733Z",
  "name": "inspired-termite-namespace",
  "owner": "jackdelahunt",
  "quota": {
    "connectors": 4,
    "cpu_limits": "2",
    "cpu_requests": "1",
    "memory_limits": "2Gi",
    "memory_requests": "1Gi"
  },
  "resource_version": 863187,
  "status": {
    "connectors_deployed": 0,
    "state": "disconnected"
  },
  "tenant": {
    "id": "jackdelahunt",
    "kind": "user"
  }
}
Successfully created the "" namespace

@avano avano force-pushed the namespace-create-fix branch from c898018 to db49fe8 Compare October 27, 2022 12:08
@avano
Copy link
Contributor Author

avano commented Oct 27, 2022

thanks Jack, that was a different issue - the logged name was always from the --name xyz command option, not from the actual namespace created. hopefully fixed now:

./rhoas connector namespace create
{
  "annotations": {
    "connector_mgmt.bf2.org/profile": "evaluation-profile"
  },
  "cluster_id": "c9nrsjtcqpu8pmmjl5vg",
  "created_at": "2022-10-27T12:07:35.414848Z",
  "expiration": "2022-10-29T12:07:35.412037Z",
  "href": "/api/connector_mgmt/v1/kafka_connector_namespaces/cdd791vb1fq06fd8eq1g",
  "id": "cdd791vb1fq06fd8eq1g",
  "kind": "ConnectorNamespace",
  "modified_at": "2022-10-27T12:07:35.414848Z",
  "name": "regular-boar-namespace",
  "owner": "[email protected]",
  "quota": {
    "connectors": 4,
    "cpu_limits": "2",
    "cpu_requests": "1",
    "memory_limits": "2Gi",
    "memory_requests": "1Gi"
  },
  "resource_version": 863191,
  "status": {
    "connectors_deployed": 0,
    "state": "disconnected"
  },
  "tenant": {
    "id": "[email protected]",
    "kind": "user"
  }
}
Successfully created the "regular-boar-namespace" namespace

@avano avano changed the title fix(namespace): Fix brackets in logger fix(namespace): fix namespace name logging Oct 27, 2022
@jackdelahunt
Copy link
Contributor

LGTM 👍

@jackdelahunt jackdelahunt merged commit 414d281 into redhat-developer:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants