Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error handler overwrite now works as intended #1735

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix: error handler overwrite now works as intended #1735

merged 1 commit into from
Aug 23, 2022

Conversation

jackdelahunt
Copy link
Contributor

Before:
image

After:
image

Verification Steps

  1. Run rhoas connector build --type=data_generator_0.1 and should be able to create json config fine

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@jackdelahunt jackdelahunt requested a review from wtrocki August 23, 2022 15:27
@jackdelahunt jackdelahunt merged commit 435710e into main Aug 23, 2022
@jackdelahunt jackdelahunt deleted the error_handler_fix branch August 23, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackdelahunt @wtrocki