-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: can now update kafka when only owner #1724
Conversation
95e3265
to
f169f14
Compare
go.sum changes were from |
So backend doesnt allow to change owner? One cannot give their kafka to someone else? |
Not sure about the actual action itself, but in the implementation that we have we try and select the owner from a list of other people and to get this list it requires to to be org admin. |
pkg/cmd/kafka/update/update.go
Outdated
return err | ||
} | ||
} else { | ||
opts.owner = kafkaInstance.GetOwner() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should askForNewOwnerName - as opposed to select for admin.
Current logic does assign the same owner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in enter the name directly as the select is for admins only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Long:
Only admins can fetch users but anyone can put username that they know and should be able to give their kafka away.
Running
rhoas kafka update reauthentication false
was not allowed as you needed to be a org admin.This pr allows for kafka owners to update the kafka reauthentication option and also skips prompt they are not allowed to change as they are not org admins.
Verification Steps
rhoas kafka update reauthentication=false
when not being org admin, this will failrhoas kafka update reauthentication false
and should work finerhoas kafka update
and should only be able to change reauthentication an not ownerType of change