Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generate-config): update success message and default path for env #1676

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

rkpattnaik780
Copy link
Contributor

This is a follow up to #1588 .

The PR updates the success message printed after configs are generated.
rhoas generate-config --type env should save configurations to rhoas.env

Verification Steps

  1. Run the following command:
./rhoas generate-config --type env
  1. The command should save configurations in rhoas.env.
Configurations successfully saved to "/home/rkpattnaik780/coding/redhat/mk/cli/rhoas.env"

You can now use existing service accounts or create new to connect to the services.
To create new service account, run this command:

  $ rhoas service-account create

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@wtrocki
Copy link
Collaborator

wtrocki commented Jul 25, 2022

I would personally go with config.env but rhoas.env is ok.

@wtrocki wtrocki merged commit 79ea694 into main Jul 25, 2022
@wtrocki wtrocki deleted the default_generate_2 branch July 25, 2022 08:06
rkpattnaik780 added a commit that referenced this pull request Jul 26, 2022
rkpattnaik780 added a commit that referenced this pull request Jul 26, 2022
… for env (#1676)"

This reverts commit 79ea694.

Signed-off-by: Ramakrishna Pattnaik <[email protected]>
rkpattnaik780 added a commit that referenced this pull request Jul 26, 2022
… for env (#1676)"

This reverts commit 79ea694.

Signed-off-by: Ramakrishna Pattnaik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants