Connector type list #1641
Merged
Connector type list #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackdelahunt
force-pushed
the
connector-type-list
branch
from
05b1d2f to
baf97d7
Compare
wtrocki
reviewed
Jul 14, 2022
| @@ -36,6 +37,8 @@ func NewConnectorsCommand(f *factory.Factory) *cobra.Command { | |||
| use.NewUseCommand(f), | |||
| start.NewStartCommand(f), | |||
| stop.NewStopCommand(f), | |||
| connector_type.NewTypeCommand(f), | |||
There was a problem hiding this comment.
This is due to type being a reserved word in go. I just went with connector_type instead.
wtrocki
reviewed
Jul 14, 2022
wtrocki
reviewed
Jul 14, 2022
|
|
||
| if err != nil { | ||
| switch httpRes.StatusCode { | ||
| case http.StatusUnauthorized: |
There was a problem hiding this comment.
This is antipattern. We should not use status codes for validation. We should use error codes.
See kafka create for example
wtrocki
reviewed
Jul 14, 2022
|
|
||
| flags := connectorcmdutil.NewFlagSet(cmd, f) | ||
| flags.AddOutput(&opts.outputFormat) | ||
| flags.IntVar(&opts.limit, "limit", 150, f.Localizer.MustLocalize("connector.type.list.flag.page.description")) |
There was a problem hiding this comment.
I think we should use build package limits here as in other implementations
wtrocki
reviewed
Jul 14, 2022
| flags.AddOutput(&opts.outputFormat) | ||
| flags.IntVar(&opts.limit, "limit", 150, f.Localizer.MustLocalize("connector.type.list.flag.page.description")) | ||
| flags.StringVar(&opts.search, "search", DefaultSearch, f.Localizer.MustLocalize("connector.type.list.flag.search.description")) | ||
| flags.IntVar(&opts.page, "page", 1, f.Localizer.MustLocalize("connector.type.list.flag.page.description")) |
There was a problem hiding this comment.
Is pagination starting from 0? :)
There was a problem hiding this comment.
afaik 1 is the start and when passing 0 it just gives the same output as 1 anyway
There was a problem hiding this comment.
Yes. That is common pattern
wtrocki
approved these changes
Jul 14, 2022
|
Can be fixed on separate PR |
wtrocki
pushed a commit
that referenced
this pull request
Jul 18, 2022
wtrocki
pushed a commit
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification Steps
rhoas connector type listrhoas connector type list --output=yamlrhoas connector type list --limit=5rhoas connector type list --search=Amazon%rhoas connector type list --limit=15 --page=2Type of change