Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-registry create): fetch registry URL after creation #1580

Merged
merged 3 commits into from
May 25, 2022

Conversation

rkpattnaik780
Copy link
Contributor

rhoas service-registry create now fetches registry URL and shows correct compatibility endpoints.

Closes #1574

Verification Steps

  1. Run the following command to create a registry:
rhoas service-registry create
  1. You should be able to see the registry URL along with compatibility endpoints once creation is successful.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@rkpattnaik780 rkpattnaik780 requested a review from wtrocki May 25, 2022 07:38
return err
}

compatibleEndpoints := registrycmdutil.GetCompatibilityEndpoints(registry.GetRegistryUrl())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trick is that this is async call so when I run this pointed to local it can still return nil

Suggested change
compatibleEndpoints := registrycmdutil.GetCompatibilityEndpoints(registry.GetRegistryUrl())
if registry.GetRegistryUrl() != nil {
compatibleEndpoints := registrycmdutil.GetCompatibilityEndpoints(registry.GetRegistryUrl())
} else {
// To get list of compatible endpoints please run `describe` command
}

@wtrocki
Copy link
Collaborator

wtrocki commented May 25, 2022

I have run this with local service registry for testing. I think in more than 70% of cases without huge load users should see endpoints anyway.

@wtrocki wtrocki merged commit 5f71a87 into main May 25, 2022
@wtrocki wtrocki deleted the registry_url_issue branch May 25, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service registry create missing details for connection urls
2 participants