Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service-account): enable credentials to be saved as secret #1575

Merged
merged 1 commit into from
May 25, 2022
Merged

feat(service-account): enable credentials to be saved as secret #1575

merged 1 commit into from
May 25, 2022

Conversation

rkpattnaik780
Copy link
Contributor

Enable kubernetes secret output for service-accounts.

Verification Steps

  1. Create service-account with output-format
./rhoas service-account create --short-description k8s-secret --file-format secret
  1. Reset credentials for a service-account
./rhoas service-account reset-credentials

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@rkpattnaik780 rkpattnaik780 requested a review from wtrocki May 17, 2022 18:09
@wtrocki
Copy link
Collaborator

wtrocki commented May 25, 2022 •
edited
Loading

I totally missed that PR initially. Amazing work. Verified end to end.

@wtrocki wtrocki merged commit 71e66bb into main May 25, 2022
@wtrocki wtrocki deleted the svc_acc_secret branch May 25, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkpattnaik780 @wtrocki