Addressing feedback for instance sizes #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: This change is introduced to reflect what this flag does. We have been adding numerous checks that some developers and CI environments want to skip.
With developer instances/standard instances of single size we can skip ask for the size completely.
|
Found bug when testing this. For standard instance we actually need to enforce size being specified :( |
|
Because of compatibility layer we can avoid specifying size for standard instance. @pb82 do you plan to remove that capability at some point. It is important for us to not break existing clients that create kafka with just specifying name. I can code some layer that picks first size from the list and use it, but It would be better to keep that logic on backend instead. |
|
@wtrocki there are no plans to remove the ability to skip the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor sizes to introduce better handling: