-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service-registry rule): add disable and and update command #1444
Conversation
Ok to look? |
Okay except the |
Me thinking: can disable be just flag as part of the update? Does this make your life easier? If not ignore |
I will prefer having a separate disable command. |
@wtrocki I wanted update to have interactive mode too, for suggesting valid config values. The problem is that unlike |
verifying now |
@rkpattnaik780 I see some strange behaviour where text with progress disappears
and then it is gone in less than second which is making it very hard to read etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified all commands:
- Global rules
- rules for artifact.
Made incompatible changes with rule applied and artifact update was rejected.
Disable and update command for service-registry rules.
Verification Steps
Type of change
Checklist