Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse yq version for different outputs #1388

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

craicoverflow
Copy link
Contributor

@craicoverflow craicoverflow commented Jan 19, 2022

YAML output was not being output in color due to a change in the output text of yq --version, from which we detect the YQ version.

Verification

Prerequisites

  • yq 4.x

Run rhoas kafka describe -o yaml and verify that it has been colored.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@wtrocki
Copy link
Collaborator

wtrocki commented Jan 19, 2022

This is good change. In long run it will be good to minimize dependency on yq or any external tool.

@craicoverflow
Copy link
Contributor Author

This is good change. In long run it will be good to minimize dependency on yq or any external tool.

Agreed 100%, the new guidelines will be adding that bit and so we can change it then when implementing the guidelines.

@craicoverflow craicoverflow merged commit 1dfb992 into redhat-developer:main Jan 19, 2022
@craicoverflow craicoverflow deleted the fix-yq branch January 19, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants