fix(kafka acl): disallow all alias for principal #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craicoverflow
approved these changes
Nov 23, 2021
| @@ -83,7 +83,7 @@ func NewAdminACLCommand(f *factory.Factory) *cobra.Command { | |||
| } | |||
|
|
|||
| // user and service account should not allow wildcard | |||
| if userID == aclutil.Wildcard || serviceAccount == aclutil.Wildcard { | |||
| if userID == aclutil.Wildcard || serviceAccount == aclutil.Wildcard || userID == aclutil.AllAlias || serviceAccount == aclutil.AllAlias { | |||
There was a problem hiding this comment.
How about if aclutil.GetResourceName(userID) == aclutil.Wildcard
There was a problem hiding this comment.
I don't think it will be a good idea to use GetResourceName at places that don't support alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka acl commands should restrict user from setting principal value to
allalong with*.Closes #1330
Verification Steps
Type of change
Checklist