feat: token-based login #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craicoverflow
force-pushed
the
restore-token-login
branch
from
b2e62fb to
bd562a3
Compare
|
CC @pmuir |
|
Verifying this! |
wtrocki
reviewed
Dec 8, 2020
| @@ -87,6 +89,8 @@ func NewLoginCmd() *cobra.Command { | |||
| cmd.Flags().StringVar(&args.url, "url", stagingURL, "URL of the API gateway. The value can be the complete URL or an alias. The valid aliases are 'production', 'staging', 'integration', 'development' and their shorthands.") | |||
| cmd.Flags().BoolVar(&args.insecureSkipTLSVerify, "insecure", false, "Enables insecure communication with the server. This disables verification of TLS certificates and host names.") | |||
| cmd.Flags().StringVar(&args.clientID, "client-id", defaultClientID, "OpenID client identifier.") | |||
| cmd.Flags().StringVar(&args.authURL, "auth-url", connection.DefaultAuthURL, "SSO Authentication server") | |||
There was a problem hiding this comment.
Would add comment to separate those flags as temp.
wtrocki
reviewed
Dec 8, 2020
README.md
Outdated
| @@ -8,7 +8,7 @@ Go to [releases](https://github.com/bf2fc6cc711aee1a0c2a/cli/releases) to downlo | |||
|
|
|||
| ## Getting Started | |||
|
|
|||
| 1. Login to RHOAS | |||
| ### Login to RHOAS | |||
|
|
|||
| ```shell | |||
| rhoas login --insecure | |||
There was a problem hiding this comment.
I would add info to qa server so it will be clear for the moment
There was a problem hiding this comment.
Added here d5d2beb (#132)
wtrocki
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #130
This PR makes it (again) possible to login with an offline token. This is a temporary workaround until a client is available on production SSO and should be removed again ASAP.
Logging in
rhoas login --token $TOKEN --client-id cloud-servicesSide note
This now means that to log in using the authorization code flow, you must specify the auth URL: