fix: update terms spec url #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ SHELL = bash | |||
| RHOAS_VERSION ?= "dev" | |||
| REPOSITORY_OWNER ?= "redhat-developer" | |||
| REPOSITORY_NAME ?= "app-services-cli" | |||
| TERMS_SPEC_URL ?= "https://raw.githubusercontent.com/redhat-developer/app-services-ui/main/static/configs/terms-conditions-spec.json" | |||
| TERMS_SPEC_URL ?= "https://console.redhat.com/apps/application-services/terms-conditions-spec.json" | |||
There was a problem hiding this comment.
We will probably want a different one for stage and prod?
There was a problem hiding this comment.
Not sure why we would need it?
There was a problem hiding this comment.
Spec file could be different between stage and prod versions
There was a problem hiding this comment.
We do not have ability to detect env and we need more sophisticated remote config for massso. I think this requirement would need more design etc.
If we need config agains stage I think we should build different version of cli for now
There was a problem hiding this comment.
I think this tc config should be refactored to more generic config. Created issue to cover this work but this is out of scope of current PR
craicoverflow
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use production based json file.
use termsandconditions file for verification